Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore threads parameter on Windows #192

Merged
merged 3 commits into from
Mar 3, 2022
Merged

Ignore threads parameter on Windows #192

merged 3 commits into from
Mar 3, 2022

Conversation

odow
Copy link
Member

@odow odow commented Mar 2, 2022

x-ref #186

@odow odow mentioned this pull request Mar 2, 2022
Closed
odow
odow commented Mar 2, 2022
View reviewed changes
src/MOI_wrapper/MOI_wrapper.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 2, 2022 •
edited
Loading

Codecov Report

Merging #192 (16a1d74) into master (d06d1eb) will increase coverage by 0.16%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
+ Coverage   57.64%   57.81%   +0.16%     
==========================================
  Files           3        3              
  Lines         510      512       +2     
==========================================
+ Hits          294      296       +2     
  Misses        216      216
Impacted Files Coverage Δ
src/MOI_wrapper/MOI_wrapper.jl 86.49% <87.50%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d06d1eb...16a1d74. Read the comment docs.

@odow odow merged commit e76d4b6 into master Mar 3, 2022
@odow odow deleted the od/warn-threads branch March 3, 2022 00:27
matteorossini added a commit to Electa-Git/FlexPlan.jl that referenced this pull request Apr 19, 2022
@matteorossini
Disable multiple threads for Cbc solver on Windows
a555593 
Cbc cannot be used on Windows with multiple threads: <jump-dev/Cbc.jl#186>
The `threads` argument is already disabled on Windows since Cbc v1.0.0: <jump-dev/Cbc.jl#192>
We cannot use Cbc v1.0.0 at the moment because it requires MathOptInterface v1 and we require MathOptInterface v0.10.9.
Removal of MathOptInterface from FlexPlan.jl dependencies is to be done: <#121 (comment)>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlubin mlubin mlubin left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odow @mlubin