Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix writing options that contain spaces #197

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Fix writing options that contain spaces #197

merged 2 commits into from
Feb 17, 2025

Conversation

odow
Copy link
Member

@odow odow commented Feb 16, 2025

Closes #196

The Cmd wraps things in ' ', but this happens to the entire 'output_file=/path/to/file.txt', and the binary fails to parse that.

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.87%. Comparing base (9e5b590) to head (b035c60).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   98.80%   98.87%   +0.06%     
==========================================
  Files           1        1              
  Lines          84       89       +5     
==========================================
+ Hits           83       88       +5     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow merged commit 66c1540 into master Feb 17, 2025
13 checks passed
@odow odow deleted the od/space-option branch February 17, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Escape spaces in cmd
1 participant