Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed url trailing slashes problem #9

Closed
wants to merge 1 commit into from
Closed

Fixed url trailing slashes problem #9

wants to merge 1 commit into from

Conversation

rghose
Copy link
Contributor

@rghose rghose commented Mar 10, 2014

Mainly because of:
return rtrim($this->providerConfig['issuer'], '/') . '/'; in the function used.

Mainly because of:
return rtrim($this->providerConfig['issuer'], '/') . '/'; in the function used.
@jricher
Copy link
Collaborator

jricher commented Mar 10, 2014

This looks like a dangerous change to me because it's doing a kind of normalization on the issuer URL. This can't be guaranteed to be consistent across different IdPs.

@jumbojett
Copy link
Owner

@rghose Thanks for submitting the pull request. Your code does fix the issue.

@jricher is correct in stating that our library should not be normalizing the URL. I'll be updating the library shortly to remove the for-mentioned code snippet.

@jumbojett jumbojett closed this Mar 10, 2014
@rghose rghose deleted the patch-2 branch March 11, 2014 06:55
@brunopenso brunopenso mentioned this pull request Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants