Enabled client_secret_basic authentication on refreshToken()
#215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azmeuk
reviewed
Nov 21, 2021
src/OpenIDConnectClient.php
Outdated
| @@ -812,6 +812,9 @@ protected function requestTokens($code) { | |||
| */ | |||
| public function refreshToken($refresh_token) { | |||
| $token_endpoint = $this->getProviderConfigValue('token_endpoint'); | |||
| $token_endpoint_auth_methods_supported = $this->getProviderConfigValue('token_endpoint_auth_methods_supported', ['client_secret_basic', 'client_secret_post']); | |||
There was a problem hiding this comment.
According to the spec, the default should be client_secret_basic only, however this does not really change the rest of the patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of common tasks a pull request require complete
Effectively updated the
refreshToken()behavior to matchrequestToken()behavior and acceptclient_secret_basicauthentication.Eventually can update to have all token_endpoints loop through
token_endpoint_auth_methods_supportedand pick the first available option. I'd also suggest makinggetProviderConfigValue()public and adding asetProviderConfigValue()to force the usage of specific authentication, encoding etc.