Add support for signature verification #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JWT data is "Base64 URL encoded", which is RFC4648, section 5 "Base 64 Encoding with URL and Filename Safe Alphabet". This differs from regular Base64 in characters 62 and 63, and any trailing padding characters are omitted. Add a helper function to perform the transformation and restore padding before passing it to PHP's base64_decode.
This adds support for verifying RSA signatures on JWTs. It uses phpseclib's crypto implementation. If phpseclib is unavailable, it will print a warning, and will not attempt to verify signatures.
jumbojett
added a commit
that referenced
this pull request
Nov 24, 2014
Add support for signature verification
|
Thank you @jdreed |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In working on expanding our documentation for our OIDC deployment at MIT, I noticed that none of the PHP libraries out there seem to verify signatures. This adds preliminary support for verifying signatures (RSA only), using phpseclib.
It also ensures that the base64urlencoded data is decoded correctly, by implementing base64 url decoding as described in RFC4648 section 5, "Base 64 Encoding with URL and Filename Safe Alphabet"