working with openAM #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $headers = array_merge($headers, $extra_headers); | ||
|
|
||
| if( sizeof($headers)>0 ) | ||
| file_put_contents($log_file,"Extra headers: ". serialize($headers)."\n",FILE_APPEND); |
There was a problem hiding this comment.
Bad idea to log extra headers that might contain access tokens and the like, isn't it?
There was a problem hiding this comment.
Ah that is debug code, crept into here.
debugging code got into prod
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finally got it working with OpenAM's oauth2 openid connect implementation. I believe this is also openID connect compliant. Fixed some inconsistencies from the document this implementation had. Also, the token request phase was behaving badly, made a quick fix not very clean though. Would be useful if you find a better fix.