Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go 1.22+ support #23

Merged
merged 2 commits into from
Oct 14, 2024
Merged

go 1.22+ support #23

merged 2 commits into from
Oct 14, 2024

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Oct 2, 2024

fixes #21

@grosser
Copy link
Contributor Author

grosser commented Oct 13, 2024

@julz can you check this PR ?

@julz
Copy link
Owner

julz commented Oct 14, 2024

thanks, looks like github actions has some complaints tho 🤔

@grosser
Copy link
Contributor Author

grosser commented Oct 14, 2024

welp need another approval 😞

@grosser
Copy link
Contributor Author

grosser commented Oct 14, 2024 •
edited
Loading

idk how this is supposed to work :/
... go 1.22.0 is invalid for 1.20
but go 1.22 is invalid for 1.22 🫨

@grosser
Copy link
Contributor Author

grosser commented Oct 14, 2024

got it now 🤞
... can't use latest version of the tools because they need >1.22

@julz
Copy link
Owner

julz commented Oct 14, 2024

awesome looks good now, thank you!

@julz julz merged commit 07c67e5 into julz:main Oct 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build broken on go 1.22
2 participants
@grosser @julz