Comment and test cleanups

Signed-off-by: Julius Volz <[email protected]>
juliusv · May 11, 2019 · 18dfe0e · 18dfe0e
1 parent 7eb76b9
commit 18dfe0e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/promflux/aggregate_expr.go b/promflux/aggregate_expr.go
@@ -78,6 +78,7 @@ func (t *transpiler) transpileAggregateExpr(a *promql.AggregateExpr) (ast.Expres
 	aggArgs := map[string]ast.Expression{}
 
 	if a.Op == promql.ItemTopK || a.Op == promql.ItemBottomK {
+		// TODO: Allow any constant scalars here.
 		// The PromQL parser already verifies that a.Param is a scalar.
 		n, ok := a.Param.(*promql.NumberLiteral)
 		if !ok {
@@ -90,6 +91,7 @@ func (t *transpiler) transpileAggregateExpr(a *promql.AggregateExpr) (ast.Expres
 	}
 
 	if a.Op == promql.ItemQuantile {
+		// TODO: Allow any constant scalars here.
 		// The PromQL already verifies that a.Param is a scalar.
 		n, ok := a.Param.(*promql.NumberLiteral)
 		if !ok {

diff --git a/promflux/query_test.go b/promflux/query_test.go
@@ -140,8 +140,7 @@ var queries = []struct {
 
 	// Binary operators.
 	{
-		query:       `1 * 2 + 4 / 6 - 10`,
-		variantArgs: []string{""},
+		query: `1 * 2 + 4 / 6 - 10`,
 	},
 	{
 		query:       `demo_num_cpus + (1 {{.compBinOp}} bool 2)`,