Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for play-json 3.x #91

Closed
matmannion opened this issue Nov 8, 2023 · 2 comments · Fixed by #92 or #95
Closed

Support for play-json 3.x #91

matmannion opened this issue Nov 8, 2023 · 2 comments · Fixed by #92 or #95

Comments

@matmannion
Copy link
Contributor

The play-json team changed the groupId for the dependency from org.typesafe.play to org.playframework for 3.x and later (https://github.com/playframework/play-json/releases/tag/3.0.0).

As a workaround, it still uses the same package names so this library can be used by including the dependency directly and adding an exclusion rule, e.g.

libraryDependencies ++= Seq(
  "org.playframework" %% "play-json" % "3.0.1",
  "org.julienrf" %% "play-json-derived-codecs" % "10.1.0"
)

excludeDependencies ++= Seq(
  // As of Play 3.0, groupId has changed to org.playframework; exclude transitive dependencies to the old artifacts
  ExclusionRule(organization = "com.typesafe.play")
)

It may be worth marking the dependency as Optional in the library, to avoid pulling in incompatible play-json dependencies as various libraries update to support 3.x

@julienrf
Copy link
Owner

julienrf commented Nov 8, 2023

I think we should cut a new release where we update the dependency to play-json 3.x. Would you be interested in submitting a PR for that?

@matmannion
Copy link
Contributor Author

No problem, will get that submitted today

matmannion added a commit to matmannion/play-json-derived-codecs that referenced this issue Nov 9, 2023
julienrf added a commit that referenced this issue Apr 11, 2024
Update play-json dependency to 3.x, update README. Fixes #91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants