More thingies #14
Merged
More thingies #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the concept of layout `overrides` to add custom attributes to the <body /> and <main /> tags.
This also refactor frontmatter props to use `MarkdownLayoutProps` as they should.
julien-deramond
pushed a commit
that referenced
this pull request
Mar 6, 2023
* fix: pass down astro props to base layout * feat: 404 page ui This commit introduces the concept of layout `overrides` to add custom attributes to the <body /> and <main /> tags. * fix: remove unused exports * docs: document base layout props This also refactor frontmatter props to use `MarkdownLayoutProps` as they should. * feat: 404 page title * chore: remove 404 description todo already handled * feat: docs layout body overrides * feat: add MastHead component
julien-deramond
pushed a commit
that referenced
this pull request
Mar 24, 2023
* fix: pass down astro props to base layout * feat: 404 page ui This commit introduces the concept of layout `overrides` to add custom attributes to the <body /> and <main /> tags. * fix: remove unused exports * docs: document base layout props This also refactor frontmatter props to use `MarkdownLayoutProps` as they should. * feat: 404 page title * chore: remove 404 description todo already handled * feat: docs layout body overrides * feat: add MastHead component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overrides
Any page using the base layout or any other layout using the base layout now has the ability to override HTML attributes for the
bodyandmaintags.This is entirely typed, meaning you also get proper autocomplete for the attributes you can override and errors for invalid attributes.
Base layout props documentation
I tried to comment the props available to the base layout, so that it's easier to understand what's going on.