-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added line and charPositionInLine to ParseTreeNode #42
Conversation
@@ -246,13 +255,28 @@ public int getSidx() { | |||
} | |||
|
|||
/** | |||
* get ent index | |||
* get end index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for fixing this 👍🏼
This is awesome @calogero81! Thank you very much for you contribution. |
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
============================================
+ Coverage 73.42% 73.60% +0.18%
- Complexity 347 349 +2
============================================
Files 44 44
Lines 1366 1383 +17
Branches 139 141 +2
============================================
+ Hits 1003 1018 +15
Misses 275 275
- Partials 88 90 +2
Continue to review full report at Codecov.
|
Thank you, @julianthome, bumped version and updated README.md file. |
Awesome! Thanks again @calogero81 👍🏼 |
This is a proposal to add begin line and begin char position in line to ParseTreeNode