Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added line and charPositionInLine to ParseTreeNode #42

Merged
merged 2 commits into from May 12, 2021
Merged

Added line and charPositionInLine to ParseTreeNode #42

merged 2 commits into from May 12, 2021

Conversation

ghost
Copy link

@ghost ghost commented Apr 27, 2021

This is a proposal to add begin line and begin char position in line to ParseTreeNode

@@ -246,13 +255,28 @@ public int getSidx() {
}

/**
* get ent index
* get end index
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this 👍🏼

@julianthome
Copy link
Owner

julianthome commented May 9, 2021

This is awesome @calogero81! Thank you very much for you contribution.
LGTM
As part of this PR, could you bump the version of inmemantlr to 1.9.0 and add your name in the Authors and major contributors section of the README.md file?

@julianthome julianthome self-assigned this May 9, 2021
@julianthome julianthome linked an issue May 9, 2021 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2021

Codecov Report

Merging #42 (aa52ef9) into master (9b52d7d) will increase coverage by 0.18%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #42      +/-   ##
============================================
+ Coverage     73.42%   73.60%   +0.18%     
- Complexity      347      349       +2     
============================================
  Files            44       44              
  Lines          1366     1383      +17     
  Branches        139      141       +2     
============================================
+ Hits           1003     1018      +15     
  Misses          275      275              
- Partials         88       90       +2     
Impacted Files Coverage Δ Complexity Δ
...g/snt/inmemantlr/listener/DefaultTreeListener.java 85.45% <75.00%> (-2.55%) 12.00 <0.00> (ø)
...c/main/java/org/snt/inmemantlr/tree/ParseTree.java 87.50% <100.00%> (ø) 27.00 <1.00> (ø)
...in/java/org/snt/inmemantlr/tree/ParseTreeNode.java 89.18% <100.00%> (+1.31%) 35.00 <2.00> (+2.00)
...org/snt/inmemantlr/utils/ParseTreeManipulator.java 91.42% <100.00%> (+1.10%) 6.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b52d7d...aa52ef9. Read the comment docs.

@ghost
Copy link
Author

ghost commented May 11, 2021

Thank you, @julianthome, bumped version and updated README.md file.

@julianthome
Copy link
Owner

Awesome! Thanks again @calogero81 👍🏼

@julianthome julianthome merged commit 5018606 into julianthome:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line and Column Error in ParseTreeNode
3 participants