-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: read inverted datamatrix #1071
base: master
Are you sure you want to change the base?
feat: read inverted datamatrix #1071
Conversation
Interesting. Did you manage to do some performance profiling on this? Inverting each frame might be expensive to do (I think). A bit sad we have to pull in |
No I didn't. We need it so short time, that it really makes no difference, and it didn't feel slow on phones tested. |
I remember doing this for a client of mine, on a native solution, I had to use opencv too. |
After creating #1214 to enhance your PR, on Android I've seen that the inverted image is shrink, I'm working on fixing it on my branch and I will create a PR on yours as well @petri-lipponen-movesense |
Here's a quick stab at adding support for reading inverted data matrixes that the MLKit does not support. The iOS implementation is a bit clumsy (I'm not an iOS coder), but Android one is quite straight forward. Tested and works in Android & iOS. Feel free to modify, include or leave be as you will.
Future idea: add "tryInverted" which duplicates each frame and tries normal and inverted both.