Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: read inverted datamatrix #1071

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

petri-lipponen-movesense

Here's a quick stab at adding support for reading inverted data matrixes that the MLKit does not support. The iOS implementation is a bit clumsy (I'm not an iOS coder), but Android one is quite straight forward. Tested and works in Android & iOS. Feel free to modify, include or leave be as you will.

Future idea: add "tryInverted" which duplicates each frame and tries normal and inverted both.

@petri-lipponen-movesense petri-lipponen-movesense changed the title Feature: read inverted datamatrix feat: read inverted datamatrix May 20, 2024
@navaronbracke
Copy link
Collaborator

Interesting. Did you manage to do some performance profiling on this? Inverting each frame might be expensive to do (I think). A bit sad we have to pull in opencv for this to work

@petri-lipponen-movesense
Copy link
Author

Interesting. Did you manage to do some performance profiling on this? Inverting each frame might be expensive to do (I think). A bit sad we have to pull in opencv for this to work

No I didn't. We need it so short time, that it really makes no difference, and it didn't feel slow on phones tested.
I agree, it really is a bummer that the opencv is needed. There has to be better way to do it on both systems, but I just needed something that works with minimum effort and those came up on stackoverflow 😁 .

@RafaRuiz
Copy link

I remember doing this for a client of mine, on a native solution, I had to use opencv too.

@RafaRuiz
Copy link

After creating #1214 to enhance your PR, on Android I've seen that the inverted image is shrink, I'm working on fixing it on my branch and I will create a PR on yours as well @petri-lipponen-movesense
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants