Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring #6

Merged
merged 26 commits into from
Aug 14, 2020
Merged

Refactoring #6

merged 26 commits into from
Aug 14, 2020

Conversation

julianpomper
Copy link
Owner

Refactor the whole structure to be able to handle threads better, improve binding in SwiftUI and improve the usability.

Fixing:

Special thanks to @rm98 for pointing out those issues

oanhof and others added 2 commits July 30, 2020 19:39
@oanhof
create single state stream, added examle app, added transform functio…
a6f03d1 
…ns, support for sync mutations (for SwiftUI Binding and Animations), added BaseReactor, added some tests
split up in files, added Mutations initializer
51463a2
This was linked to issues Aug 1, 2020
Concurrency Crash / Issue #3
Closed
Cancellable stored for every executed action #4
Closed
Testability of Reactors #5
Closed
oanhof
oanhof approved these changes Aug 1, 2020
View reviewed changes
Sources/SwiftUIReactor/Reactor.swift Outdated Show resolved Hide resolved
oanhof
oanhof previously approved these changes Aug 1, 2020
View reviewed changes
@oanhof oanhof self-requested a review August 2, 2020 21:55
Julian Pomper and others added 11 commits August 8, 2020 11:16
small changes to the InternalState struct, added transform to the README
a1d95ca
removed (possibly) unecessary thread lock
1123083
@oanhof
Changed ActionBinding to support nested reactors, removed MutationBin…
c0810e6 
…ding, added EnvironmentReactor property wrapper
@oanhof
Merge remote-tracking branch 'refs/remotes/origin/refactoring'
ecaf7f3
@oanhof
added missing public modifiers, fixed example app build
aba4514
@oanhof
fix build for older Swift version < 5.3
9b310d1
edited README: added reactor protocol description, restructured advan…
84ef77b 
…ced section
Merge branch 'refactoring' of github.com:julianpomper/SwiftUIReactor …
61bf54e 
…into refactoring
fixed missing comment slash and added a reference to the example project
e5d4e07
update readme for new bindings and nested reactor
7acba8f
Add UIKit Helper and Instructions (#8)
44a810a 
* added uikit

* added tests

* updated README UIKit instructions, added BaseReactorViewController, added more UIKit tests

* small changes

Co-authored-by: Julian Pomper <[email protected]>
Julian Pomper and others added 4 commits August 13, 2020 09:55
updated the README with more examples, updated the uikit library for …
d935e98 
…tests
rename to SwiftyReactor (#9)
ee9d878 
* rename to SwiftyReactor

* updated urls for master branch

* fixed spacings
fixed typo in README
2725b00
Renaming#2 (#10)
9f310a1 
* renamed to SwiftReactor

* fixed example
@julianpomper julianpomper marked this pull request as ready for review August 14, 2020 11:41
@julianpomper julianpomper dismissed oanhof’s stale review August 14, 2020 11:45

Approved old changes. Needs a new review

@julianpomper julianpomper merged commit 918f068 into master Aug 14, 2020
@julianpomper julianpomper deleted the refactoring branch August 14, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oanhof oanhof oanhof approved these changes

Assignees

@oanhof oanhof

@julianpomper julianpomper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testability of Reactors Cancellable stored for every executed action Concurrency Crash / Issue
2 participants
@julianpomper @oanhof