Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default to non-required value #11

Merged
merged 1 commit into from
May 27, 2021

Conversation

owenvoke
Copy link
Contributor

Looks like there isn't a default for the trim input, so it fails with a YAML parse error if not provided.

This defaults to false (has to be a string for input defaults), which is the same as previous versions.

@pedrocarrico
Copy link

This is also affecting some of my CI/CD pipelines in Github Actions.

@pboutin
Copy link

pboutin commented May 26, 2021

Related: #12

@teja230
Copy link

teja230 commented May 26, 2021

This is breaking some of my CI/CD pipelines, do you have an ETA when this fix will be published?

@pedrocarrico
Copy link

@teja230 As an intermediate solution while this isn't merged you can pin it to the previous good known version, just change juliangruber/read-file-action@v1 tojuliangruber/read-file-action@74dc4b4435b60f96f84bcba916659c779f46ba0a

@juliangruber juliangruber merged commit 7f242b9 into juliangruber:master May 27, 2021
@juliangruber
Copy link
Owner

Does anyone know if there is tooling that helps you validate the schema? This repo's CI didn't fail because of that.

https://github.com/juliangruber/read-file-action/releases/tag/v1.1.2

@owenvoke owenvoke deleted the bugfix/trim-default branch May 27, 2021 10:04
@owenvoke
Copy link
Contributor Author

I think that the CI here didn't fail because the trim option was added to the workflow when the feature was intruduced. Therefore, this error wouldn't have shown up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants