Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update entrypoint.sh #2

Merged
merged 3 commits into from
Sep 19, 2019
Merged

Update entrypoint.sh #2

merged 3 commits into from
Sep 19, 2019

Conversation

odow
Copy link
Contributor

@odow odow commented Sep 17, 2019

Ref: domluna/JuliaFormatter.jl#49

I haven't done too much digging into how this works, but it looks like you need something like this?

@domluna
Copy link
Collaborator

domluna commented Sep 18, 2019

In the case of formatting JuliaFormatter.jl maybe this works but in general I believe $GITHUB_WORKSPACE will be which repo is being acted upon.

For some reason it's not remembering JuliaFormatter is installed from the Dockerfile build. Moving the install to entrypoint.sh could work but that seems a little silly.

@odow
Copy link
Contributor Author

odow commented Sep 18, 2019

Oh, good point about other packages. What about this then.

entrypoint.sh Outdated Show resolved Hide resolved
@odow
Copy link
Contributor Author

odow commented Sep 18, 2019

Okay. A slightly more clever way of doing things to doesn't mutate Project.toml.

@domluna
Copy link
Collaborator

domluna commented Sep 19, 2019

Let's see if this works 🤞

@domluna domluna merged commit 41501b7 into julia-actions:master Sep 19, 2019
@odow odow deleted the patch-1 branch September 19, 2019 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants