Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typespec): Misc fixes in typespec definitions #638

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Oct 12, 2024

Signed-off-by: Diwank Singh Tomer [email protected]


Important

Redefines ChildStreamEndpoint, updates dependencies, and removes YieldStep from task definitions in typespec files.

  • Behavior:
    • Redefines ChildStreamEndpoint in interfaces.tsp to use SSEStream<StreamEvent<T>>.
    • Removes YieldStep from task definitions in endpoints.tsp and openapi-0.4.0.yaml.
  • Models:
    • Adds StreamEvent<T> union in types.tsp.
  • Dependencies:
  • Misc:
    • Adds TasksGetRoute interface in endpoints.tsp.
    • Enables omit-unreachable-types in tspconfig.yaml.

This description was created by Ellipsis for 2f2eafe. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 2f2eafe in 26 seconds

More details
  • Looked at 474 lines of code in 9 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. typespec/tspconfig.yaml:9
  • Draft comment:
    The omit-unreachable-types option is now uncommented, which means unreachable types will be omitted from the output. Ensure this change is intentional as it may affect the generated OpenAPI specification.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The omit-unreachable-types option is now uncommented, which means unreachable types will be omitted from the output. This is a change from the previous configuration where this option was commented out.

Workflow ID: wflow_LaRK064PoTuyhJGn


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@creatorrr creatorrr merged commit fecdc81 into dev Oct 13, 2024
6 checks passed
@creatorrr creatorrr deleted the f/typespec-fixes branch October 13, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant