Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(memory-store): Make cozo_data volume external #616

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

HamadaSalhab
Copy link
Contributor

@HamadaSalhab HamadaSalhab commented Oct 8, 2024

Important

Set cozo_data volume to external in docker-compose.yml.

  • Volumes:
    • Set cozo_data volume to external: true in docker-compose.yml, aligning with cozo_backup.

This description was created by Ellipsis for 017823f. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 017823f in 10 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. memory-store/docker-compose.yml:38
  • Draft comment:
    Add a newline at the end of the file for consistency and to avoid potential issues with some tools.
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The change to make cozo_data volume external is consistent with the existing configuration for cozo_backup. However, the lack of a newline at the end of the file is a minor issue.

Workflow ID: wflow_gNisSqjDwlW9gA6M


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@HamadaSalhab HamadaSalhab merged commit 7effdd3 into dev Oct 8, 2024
6 checks passed
@HamadaSalhab HamadaSalhab deleted the f/memory-store branch October 8, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant