Feat(agents-api): Replace Retry Policies with Temporal Interceptors & Add more non-retryable errors

[HamadaSalhab]

Important

Replaces retry policies with Temporal interceptors to handle non-retryable errors and updates worker to use these interceptors.

• Interceptors:
  • Add CustomActivityInterceptor and CustomWorkflowInterceptor in interceptors.py to handle non-retryable errors by raising ApplicationError.
  • CustomInterceptor combines both activity and workflow interceptors.
• Non-Retryable Errors:
  • Define NON_RETRYABLE_ERROR_TYPES and is_non_retryable_error() in exceptions/tasks.py to identify non-retryable errors.
• Retry Policy:
  • Set DEFAULT_RETRY_POLICY to None in retry_policies.py due to conflict with interceptors.
• Worker:
  • Update create_worker() in worker.py to use CustomInterceptor.

^{This description was created by for 7a50b72. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 7a50b72 in 16 seconds

More details

• Looked at 314 lines of code in 4 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. agents-api/agents_api/common/retry_policies.py:1

• Draft comment:
  The import statements and DEFAULT_RETRY_POLICY are commented out, likely due to the FIXME note. Ensure this change doesn't affect other parts of the codebase relying on DEFAULT_RETRY_POLICY.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The import statements for timedelta and RetryPolicy are commented out, and the DEFAULT_RETRY_POLICY is set to None. This is likely intentional due to the FIXME comment indicating an issue with retry policies and interceptors. However, it's important to ensure that this change doesn't affect other parts of the codebase that might rely on DEFAULT_RETRY_POLICY.

Workflow ID: wflow_4zA7YJ6NiK4QLdxt

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[creatorrr]

@HamadaSalhab - actually how will we do maximum attempts etc without retry policies?

[HamadaSalhab]

@HamadaSalhab - actually how will we do maximum attempts etc without retry policies?

It seems like the interceptors & retry policies do not work well when both are set. I left a FIXME regarding that.