fix: Add developer_id constraints in all queries when possible

[creatorrr]

Signed-off-by: Diwank Singh Tomer [email protected]

---

Important

Add developer_id constraints to database queries and introduce environment flags for developer verification.

• Behavior:
  • Add developer_id constraints to queries in create_or_update_agent.py, get_agent.py, prepare_session_data.py, create_or_update_user.py, and patch_user.py to ensure operations are scoped to the correct developer.
  • Introduce do_verify_developer and do_verify_developer_owns_resource flags in env.py to toggle developer verification.
• Queries:
  • Modify queries in create_or_update_agent.py and get_agent.py to include developer_id in input and match conditions.
  • Update prepare_session_data.py to pass developer_id in session-related queries.
  • Add developer_id checks in create_or_update_user.py and patch_user.py for user operations.
• Utils:
  • Update verify_developer_id_query and verify_developer_owns_resource_query in utils.py to respect new environment flags.

^{This description was created by for 09d8dad. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 09d8dad in 17 seconds

More details

• Looked at 189 lines of code in 7 files
• Skipped 0 files when reviewing.
• Skipped posting 6 drafted comments based on config settings.

1. agents-api/agents_api/env.py:43

• Draft comment:
  Ensure that do_verify_developer and do_verify_developer_owns_resource are not disabled in production environments to avoid security risks.
• Reason this comment was not posted:
  Comment did not seem useful.

2. agents-api/agents_api/models/agent/create_or_update_agent.py:136

• Draft comment:
  Ensure that the developer_id constraint is correctly applied to all relevant queries to maintain data integrity in multi-tenant environments.
• Reason this comment was not posted:
  Confidence changes required: 50%
  In create_or_update_agent.py, the create_or_update_agent function constructs queries to insert or update agent records. The PR adds developer_id constraints to ensure that operations are scoped to the correct developer. This is a good practice for multi-tenant systems.

3. agents-api/agents_api/models/agent/get_agent.py:74

• Draft comment:
  The addition of developer_id in the query ensures data isolation for multi-tenant systems. Verify that this constraint is consistently applied across all relevant queries.
• Reason this comment was not posted:
  Confidence changes required: 50%
  In get_agent.py, the get_agent function now includes a developer_id constraint in the query. This ensures that only agents belonging to the specified developer are retrieved, which is crucial for maintaining data isolation in multi-tenant systems.

4. agents-api/agents_api/models/session/prepare_session_data.py:65

• Draft comment:
  Ensure that developer_id is consistently used in queries to maintain data integrity and isolation in multi-tenant environments.
• Reason this comment was not posted:
  Confidence changes required: 50%
  In prepare_session_data.py, the prepare_session_data function now includes developer_id in its queries. This ensures that session data is correctly scoped to the developer, which is important for data integrity in multi-tenant systems.

5. agents-api/agents_api/models/user/create_or_update_user.py:71

• Draft comment:
  Ensure that developer_id is consistently used in queries to maintain data integrity and isolation in multi-tenant environments.
• Reason this comment was not posted:
  Confidence changes required: 50%
  In create_or_update_user.py, the create_or_update_user function now includes developer_id in its queries. This ensures that user data is correctly scoped to the developer, which is important for data integrity in multi-tenant systems.

6. agents-api/agents_api/models/user/patch_user.py:79

• Draft comment:
  Ensure that developer_id is consistently used in queries to maintain data integrity and isolation in multi-tenant environments.
• Reason this comment was not posted:
  Confidence changes required: 50%
  In patch_user.py, the patch_user function now includes developer_id in its queries. This ensures that user updates are correctly scoped to the developer, which is important for data integrity in multi-tenant systems.

Workflow ID: wflow_QcFm5kRCXrVyozei

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.