Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev -> main #515

Merged
merged 3 commits into from
Sep 23, 2024
Merged

dev -> main #515

merged 3 commits into from
Sep 23, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Sep 23, 2024

Important

Remove depends_on conditions in Docker Compose files and update model name in litellm-config.yaml.

  • Docker Compose Changes:
    • Removed depends_on condition for temporal service in agents-api/docker-compose.yml and scheduler/docker-compose.yml to improve service startup behavior.
  • Model Configuration:
    • Updated model name from voyage/voyage-large-2 to voyage/voyage-3 in litellm-config.yaml for voyage-3 model.

This description was created by Ellipsis for d633c77. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to d633c77 in 14 seconds

More details
  • Looked at 42 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. agents-api/docker-compose.yml:72
  • Draft comment:
    Removing 'depends_on' with 'condition: service_started' might cause issues if 'temporal' is not ready before dependent services start. Consider ensuring service readiness another way.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment is speculative, as it suggests a potential issue without confirming it. The removal of 'depends_on' might not necessarily cause issues, and the comment does not provide a definite problem or solution. The comment violates the rule against speculative comments and asking the author to ensure behavior.
    I might be missing the context of how 'temporal' is used in the system, which could make the comment more relevant. However, the comment is speculative and does not provide strong evidence of an issue.
    Even if 'temporal' is crucial, the comment should provide a definite issue or solution rather than speculate. The removal might be intentional and correct.
    The comment should be deleted as it is speculative and does not provide strong evidence of an issue.
2. scheduler/docker-compose.yml:62
  • Draft comment:
    Removing 'depends_on' might cause issues if 'temporal' is not ready before dependent services start. Consider ensuring service readiness another way.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_GV76PaKNJwIlUHvE


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@creatorrr creatorrr merged commit 416459c into main Sep 23, 2024
8 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant