Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(agents-api): Fix session.situation not being rendered #499

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Sep 16, 2024

Signed-off-by: Diwank Singh Tomer [email protected]


🚀 This description was created by Ellipsis for commit 6691b62

fix(agents-api): render session.situation in chat environment

Summary:

Fix session.situation rendering in chat() and update get_chat_environment() to include agent key.

Key points:

  • Fix session.situation rendering in chat() by adding it as a system message.
  • Update get_chat_environment() to include agent key.
  • Minor code reorganization in chat.py for clarity.
  • Add pprint for debugging in chat.py.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to d50efaf in 20 seconds

More details
  • Looked at 97 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/agents_api/common/protocol/sessions.py:119
  • Draft comment:
    The agent key is redundant as current_agent already provides the same information. Consider removing the agent key.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment is about a change made in the diff, specifically the addition of the 'agent' key. The comment points out a potential redundancy, which is a valid code quality concern. Removing redundancy can improve code clarity and maintainability.
    The comment assumes that 'agent' and 'current_agent' are always the same, but there might be a context where both are needed. Without full context, it's hard to be certain.
    The comment is still useful as it prompts the author to consider if the redundancy is necessary, which is a valid code quality concern.
    Keep the comment as it addresses a potential redundancy introduced in the diff, which is a valid concern for code quality.

Workflow ID: wflow_6cLv8KpWwvlvu2Gl


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

agents-api/agents_api/routers/sessions/chat.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Incremental review on 6691b62 in 16 seconds

More details
  • Looked at 91 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_eXUj5uvzjNuT7LOC


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@creatorrr creatorrr merged commit 4ce4810 into dev Sep 16, 2024
3 of 6 checks passed
@creatorrr creatorrr deleted the x/fix-situation-not-rendered branch September 16, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant