feat(agents-api): Add YAML support #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 19, 2024 21:09
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 9962356 in 1 minute and 10 seconds
More details
- Looked at
5649lines of code in55files - Skipped
3files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. sdks/python/julep/api/types/tasks_tool_call_step.py:18
- Draft comment:
Ensure that theargumentsfield usestyping.Dict[str, CommonPyExpression]consistently across all Python files, as it is correctly done here. This matches the TypeScript equivalentRecord<string, Common_PyExpression>. - Reason this comment was not posted:
Confidence changes required:20%
The code in the Python files usestyping.Dict[str, CommonPyExpression]for theargumentsfield inToolCallStep, which is consistent across different files. However, in the TypeScript files, theargumentsfield is defined asRecord<string, Common_PyExpression>, which is the correct equivalent in TypeScript. This consistency is good and should be maintained.
Workflow ID: wflow_KCYtdRW8Z0OHkyxH
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
creatorrr
commented
Aug 20, 2024
| ]: | ||
| return await call_next(request) | ||
|
|
||
| # Parse the YAML body into a Python object |
There was a problem hiding this comment.
This should be wrapped inside a 400 try except
| @@ -89,6 +91,11 @@ def register_exceptions(app: FastAPI) -> None: | |||
| max_age=3600, | |||
| ) | |||
|
|
|||
| app.add_middleware(GZipMiddleware, minimum_size=1000, compresslevel=3) | |||
There was a problem hiding this comment.
The Authorization logic should be moved into a middleware and executed before any parsing begins
whiterabbit1983
merged commit 8263aea
into
dev-tasks-disable-routes
2 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds YAML support to the
agents-api, refactors logging, fixes codec issues, updates models and SDKs, and enhances TypeSpec definitions.Key points:
YamlMiddlewareinagents-api/agents_api/middleware.py.loggingwithactivity.loggerin task step files for error logging.agents-api/agents_api/worker/codec.py.pydanticmodels to allow extra fields and strict types.agents-api/tests/test_workflow_routes.py.Generated with ❤️ by ellipsis.dev