Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/fix codec #463

Merged
merged 4 commits into from
Aug 20, 2024
Merged

x/fix codec #463

merged 4 commits into from
Aug 20, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Aug 20, 2024

  • fix(agents-api): Fix the typespec bug and regenerate
  • refactor(agents-api): Minor refactors
  • fix(agents-api): Temporal local activities are too unreliable
  • fix(agents-api): Fix the codec, which was causing a lot of bugs

🚀 This description was created by Ellipsis for commit b2fb5a9

Summary:

This PR updates the codec to use pickle with lz4, improves logging in task steps, and enhances the TypeScript SDK with new task step support, while updating dependencies.

Key points:

  • Codec Update: Switched to pickle with lz4 compression for serialization in agents-api/agents_api/worker/codec.py.
  • Logging Update: Replaced logging with activity.logger in task step files like evaluate_step.py, if_else_step.py, etc.
  • TypeScript SDK Update: Added support for new task steps and expressions in models and schemas.
  • Dependency Update: Updated pyproject.toml and package.json for new dependencies and version changes.
  • Task Execution Workflow: Improved reliability by addressing codec and logging issues.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b2fb5a9 in 1 minute and 12 seconds

More details
  • Looked at 5374 lines of code in 50 files
  • Skipped 3 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. sdks/ts/src/api/models/Tasks_ToolCallStep.ts:17
  • Draft comment:
    Consider renaming Common_PyExpression to CommonPyExpression for consistency with Python models.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR includes changes to multiple files, primarily focusing on the use of CommonPyExpression for arguments in various models. This change is consistent across Python and TypeScript files, ensuring type safety and consistency. However, there is a minor inconsistency in the TypeScript models where Common_PyExpression is used instead of CommonPyExpression. This should be corrected for consistency with the Python models.
2. sdks/ts/src/api/schemas/$Tasks_ToolCallStep.ts:30
  • Draft comment:
    Consider renaming Common_PyExpression to CommonPyExpression for consistency with Python models.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR includes changes to multiple files, primarily focusing on the use of CommonPyExpression for arguments in various models. This change is consistent across Python and TypeScript files, ensuring type safety and consistency. However, there is a minor inconsistency in the TypeScript models where Common_PyExpression is used instead of CommonPyExpression. This should be corrected for consistency with the Python models.

Workflow ID: wflow_xTVkncxb8Z36eChq


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@whiterabbit1983 whiterabbit1983 merged commit b355113 into dev-tasks-disable-routes Aug 20, 2024
2 of 5 checks passed
@whiterabbit1983 whiterabbit1983 deleted the x/fix-codec branch August 20, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants