Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agents-api): Fix the typespec bug and regenerate #462

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Aug 20, 2024

Signed-off-by: Diwank Tomer [email protected]


🚀 This description was created by Ellipsis for commit f8111ea

Summary:

This PR fixes a typespec bug in the agents-api by allowing extra fields and using StrictBool for boolean fields, updates dependencies, and regenerates SDK models for stricter type checks.

Key points:

  • Updated ConfigDict in agents-api models to extra="allow" to handle extra fields.
  • Changed boolean fields to StrictBool in agents-api models for stricter type checking.
  • Modified pyproject.toml to include lz4 dependency and updated datamodel-codegen options.
  • Updated generate_openapi_code.sh to exit on error and added new options for code generation.
  • Regenerated Python SDK models to reflect changes in typespec, including stricter type checks and handling of extra fields.
  • Updated TypeScript SDK models and schemas to include Tasks_EvaluateStep and handle stricter type checks.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f8111ea in 57 seconds

More details
  • Looked at 4974 lines of code in 39 files
  • Skipped 3 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. sdks/python/julep/api/types/tasks_tool_call_step.py:18
  • Draft comment:
    The arguments field is now typed as typing.Dict[str, CommonPyExpression]. Ensure this change is compatible with existing code that uses this class.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR introduces a change in the TasksToolCallStep class where the arguments field is now typed as typing.Dict[str, CommonPyExpression]. This change is consistent across multiple files, ensuring that the arguments field is expected to be a dictionary with string keys and CommonPyExpression values. This change is likely intended to enforce stricter typing and ensure that the expressions are evaluated correctly. However, this change should be verified for compatibility with existing code that might be using this class.

Workflow ID: wflow_QXCPeu7GkD6LgwUp


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

--strict-nullable \
--allow-population-by-field-name \
--allow-extra-fields \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think we should turn off allow extra. It might cause more problems than it solves

@whiterabbit1983 whiterabbit1983 merged commit 95a8889 into dev-tasks-disable-routes Aug 20, 2024
2 of 5 checks passed
@whiterabbit1983 whiterabbit1983 deleted the x/fix-typespec-foreach branch August 20, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants