Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agents-api): Fix typespec for foreach step and regenerate #461

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Aug 19, 2024

Signed-off-by: Diwank Tomer [email protected]


🚀 This description was created by Ellipsis for commit 9c01928

Summary:

Updated foreach step typespec in agents-api, made reduce optional in MapReduceStep, and regenerated SDKs to reflect these changes.

Key points:

  • Updated foreach step typespec in agents-api/agents_api/autogen/Tasks.py to use specific step types instead of Any.
  • Made reduce field optional in MapReduceStep in agents-api/agents_api/autogen/Tasks.py.
  • Updated return type from CommonResourceUpdatedResponse to CommonResourceCreatedResponse in sdks/python/julep/api/client.py.
  • Regenerated Python SDK types in sdks/python/julep/api/types/ to reflect changes.
  • Updated TypeScript SDK models and schemas in sdks/ts/src/api/models/ and sdks/ts/src/api/schemas/ to align with new typespec.
  • Removed contentType header from several endpoints in typespec/common/interfaces.tsp and typespec/tasks/endpoints.tsp.

Generated with ❤️ by ellipsis.dev

@whiterabbit1983 whiterabbit1983 merged commit 633c4f7 into dev-tasks-disable-routes Aug 19, 2024
2 of 5 checks passed
@whiterabbit1983 whiterabbit1983 deleted the x/fix-typespec-foreach branch August 19, 2024 18:11
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 9c01928 in 1 minute and 37 seconds

More details
  • Looked at 1927 lines of code in 39 files
  • Skipped 2 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. sdks/python/julep/api/client.py:1709
  • Draft comment:
    The return type in the docstring should be updated to match the actual return type of the function.
        ) -> CommonResourceCreatedResponse:
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment is redundant because the change it suggests has already been implemented in the code. The return type in the docstring matches the actual return type of the function, so no further action is needed.
    I might be missing the context of whether the comment was made before or after the change was implemented. However, based on the current state of the code, the comment is unnecessary.
    Even if the comment was made before the change, the current state of the code is what matters for this review. The comment is not needed now.
    The comment should be removed because the suggested change has already been implemented in the code.
2. sdks/python/julep/api/client.py:1787
  • Draft comment:
    The return type in the docstring should be updated to match the actual return type of the function.
        return pydantic_v1.parse_obj_as(CommonResourceCreatedResponse, _response.json())  # type: ignore
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment is redundant because the change it suggests has already been implemented in the diff. The docstring and the return type in the function are consistent with each other.
    I might be missing the context of whether the comment was made before or after the change was implemented. However, based on the current state of the code, the comment is unnecessary.
    The comment is unnecessary because the suggested change is already reflected in the code. The docstring and the function's return type are consistent.
    The comment should be removed because it suggests a change that has already been made in the code.
3. sdks/python/julep/api/client.py:5468
  • Draft comment:
    The return type in the docstring should be updated to match the actual return type of the function.
        ) -> CommonResourceCreatedResponse:
  • Reason this comment was not posted:
    Marked as duplicate.
4. sdks/python/julep/api/client.py:5554
  • Draft comment:
    The return type in the docstring should be updated to match the actual return type of the function.
        return pydantic_v1.parse_obj_as(CommonResourceCreatedResponse, _response.json())  # type: ignore
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_Wv1ontBAp8ZY8gCs


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants