-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(agents-api): Make chat route tests pass #454
Conversation
Signed-off-by: Diwank Tomer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 5f91ac3 in 1 minute and 45 seconds
More details
- Looked at
1215
lines of code in32
files - Skipped
2
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. agents-api/agents_api/autogen/Chat.py:90
- Draft comment:
The type ofdelta
inChatOutputChunk
has been changed fromChatMLMessage
toInputChatMLMessage
. Ensure that this change is intended and thatInputChatMLMessage
provides all necessary fields that were previously used inChatMLMessage
. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
2. agents-api/agents_api/autogen/Entries.py:17
- Draft comment:
Therole
field inBaseEntry
has been updated to includeassistant
instead ofagent
. Ensure that all references and logic in the codebase that depend on this field are updated accordingly to handle the newassistant
role. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
3. agents-api/agents_api/autogen/Entries.py:122
- Draft comment:
Therole
field inInputChatMLMessage
has been updated to includeassistant
instead ofagent
. Ensure that all references and logic in the codebase that depend on this field are updated accordingly to handle the newassistant
role. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_ehe5DBIjxRoRbwCf
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Signed-off-by: Diwank Tomer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on dcc54c4 in 36 seconds
More details
- Looked at
180
lines of code in9
files - Skipped
2
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. typespec/chat/models.tsp:191
- Draft comment:
Thelogprobs
field inBaseChatOutput
,usage
field inBaseChatResponse
, andbytes
field inBaseTokenLogProb
should be updated to be optional to match the changes made in the TypeScript SDK.
logprobs?: LogProbResponse;
usage?: CompetionUsage;
bytes?: uint16[];
- Reason this comment was not posted:
Multiple suggestions found in comment body, which is not allowed by GitHub
Workflow ID: wflow_iGNmsuK0lpv0n58c
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Signed-off-by: Diwank Tomer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Incremental review on 6279937 in 32 seconds
More details
- Looked at
90
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_JR9jYfqLaqvjSAHE
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
): | ||
(embed, _) = mocks | ||
|
||
response = make_request( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding an assertion to check the status code of the response to ensure the request was processed successfully. For example:
response = make_request( | |
assert response.status_code == 200 |
67db1fd
into
dev-tasks-disable-routes
Signed-off-by: Diwank Tomer [email protected]
Summary:
This PR adds an
/embed
route for text embedding, refactorsChatMLMessage
toInputChatMLMessage
, updates chat logic, and includes tests and SDK updates.Key points:
/embed
route for text embedding inagents-api/routers/docs/embed.py
.ChatMLMessage
toInputChatMLMessage
across the codebase.agents-api/sessions.py
.render_template_chatml
.agents-api/search_docs_hybrid.py
.get_messages
andchat
functions./embed
route inagents-api/tests/test_docs_routes.py
.test_chat_routes.py
.Generated with ❤️ by ellipsis.dev