Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agents-api): Preliminary implementation of session.chat #453

Merged
merged 9 commits into from
Aug 12, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Aug 11, 2024

  • feat(agents-api): Fix prepare_chat_context
  • feat(agents-api): Make session.render_templates true by default
  • wip(agents-api): Implementing chat
  • feat(agents-api,typespec): Re-org some of the endpoint models for proper class inheritance
  • feat(agents-api): Add litellm client
  • feat(model-serving): Remove model-serving container
  • feat: Remove support for presets
  • feat(agents-api): Add settings to developers relation
  • feat(agents-api): Preliminary implementation of session.chat

🚀 This description was created by Ellipsis for commit 892226d

Summary:

Implemented preliminary session.chat in agents-api, reorganized models, added litellm client, and removed deprecated features.

Key points:

  • Implemented preliminary version of session.chat in agents-api.
  • Fixed prepare_chat_context in agents-api.
  • Set session.render_templates to true by default in agents-api.
  • Reorganized endpoint models for proper class inheritance in agents-api and typespec.
  • Added litellm client in agents-api.
  • Removed model-serving container and support for presets.
  • Added settings to developers relation in agents-api.
  • Updated .env.example with new environment variables.
  • Modified agents-api/agents_api/activities/embed_docs.py to use new embedding client.
  • Updated agents-api/agents_api/autogen models to reflect new chat settings and input data structures.
  • Added agents-api/agents_api/routers/sessions/chat.py for handling chat requests.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 892226d in 4 minutes and 7 seconds

More details
  • Looked at 13827 lines of code in 166 files
  • Skipped 5 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. .env.example:33
  • Draft comment:
    The removal of MODEL_API_KEY, MODEL_API_KEY_HEADER_NAME, and related model-serving environment variables needs careful review in the codebase to ensure there are no leftover references that could cause runtime errors.
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.
2. agents-api/agents_api/autogen/Agents.py:47
  • Draft comment:
    The default_settings field in the Agent model should now reference DefaultChatSettings instead of the union type that included GenerationPresetSettings, OpenAISettings, and VLLMSettings. This change aligns with the removal of the GenerationPresetSettings model and simplifies the settings structure.
    default_settings: DefaultChatSettings | None = None
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.
3. typespec/agents/models.tsp:50
  • Draft comment:
    Good use of inheritance in CreateOrUpdateAgentRequest to promote code reuse and maintainability.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR introduces a new model CreateOrUpdateAgentRequest which extends CreateAgentRequest. This model is used to handle both creation and update operations for agents, which simplifies the codebase by reusing the validation and structure of CreateAgentRequest for updates as well. This is a good practice as it promotes code reuse and maintainability.
4. agents-api/agents_api/autogen/Chat.py:271
  • Draft comment:
    The ChatSettings model should extend from DefaultChatSettings to utilize proper class inheritance and ensure all settings are consistently applied. This change will help maintain the code's maintainability and ensure consistency across settings.
model ChatSettings extends DefaultChatSettings {
    ...CommonChatSettings;
}
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_9EdggNYDYrHNrBrB


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@whiterabbit1983 whiterabbit1983 merged commit a3377dd into dev-tasks-disable-routes Aug 12, 2024
2 of 5 checks passed
@whiterabbit1983 whiterabbit1983 deleted the f/session-chat branch August 12, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants