Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new routes for docs, users, search #445

Merged
merged 6 commits into from
Aug 6, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Aug 4, 2024

  • feat(agents-api): Reimplement agents routes
  • wip(agents-api): Session routes

🚀 This description was created by Ellipsis for commit 3b6e81d

Summary:

Reimplemented agent and session routes, updated models, and modified SDKs to reflect these changes.

Key points:

  • Reimplemented agent routes in agents-api/agents_api/routers/agents.
    • Functions: create_agent, create_agent_tool, create_or_update_agent, delete_agent, delete_agent_tool, get_agent_details, list_agent_tools, list_agents, patch_agent, patch_agent_tool, update_agent, update_agent_tool.
  • Reimplemented session routes in agents-api/agents_api/routers/sessions.
    • Functions: create_or_update_session, create_session, delete_session, get_session, list_sessions, patch_session, update_session.
  • Updated models in agents-api/agents_api/models.
    • Files: create_agent, utils.
  • Updated autogen models in agents-api/agents_api/autogen.
    • Files: Chat.py, Entries.py, openapi_model.py.
  • Updated SDKs.
    • Python SDK: sdks/python/julep/api/types.
    • TypeScript SDK: sdks/ts/src/api/services/DefaultService.ts.
  • Updated TypeSpec interfaces in typespec/common/interfaces.tsp.

Generated with ❤️ by ellipsis.dev

Diwank Tomer added 2 commits August 4, 2024 17:59
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 65a0b99 in 33 seconds

More details
  • Looked at 1677 lines of code in 33 files
  • Skipped 2 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/agents_api/autogen/openapi_model.py:166
  • Draft comment:
    The introduction of the ListResponse class is a good practice as it standardizes the response format for list endpoints, enhancing API consistency and usability.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR introduces a new generic ListResponse class in openapi_model.py which is used across various list endpoints in the routers. This change is consistent and correctly implemented across the TypeScript SDK, Python SDK, and the actual API routes. This is a good practice as it standardizes the response format for all list endpoints, making the API more predictable and easier to work with for developers.

Workflow ID: wflow_7QbdtyBnpEIvPWZp


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@creatorrr creatorrr changed the title wip: new routes feat: new routes for docs, users, search Aug 5, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 3b6e81d in 50 seconds

More details
  • Looked at 1480 lines of code in 29 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. sdks/ts/src/api/services/DefaultService.ts:321
  • Draft comment:
    The implementation of agentsDocsSearchRouteSearch method correctly handles different types of search requests and constructs a proper search response. This aligns well with the backend changes and the updated models for search functionality.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR introduces new routes and updates to models and SDKs for handling documents and sessions related to agents. The changes include modifications to the search functionality, particularly around handling different types of search requests (text-only, vector, and hybrid) and the responses they generate. The TypeScript SDK and Python SDK files have been updated to reflect these changes, including new types and schemas for handling search requests and responses. The PR seems to align with the intended functionality as described, focusing on enhancing the search capabilities and ensuring the SDKs are up-to-date with the backend changes.

Workflow ID: wflow_mxJCcSuvdtgTPUY6


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@whiterabbit1983 whiterabbit1983 merged commit 2cf9af5 into dev-tasks-disable-routes Aug 6, 2024
2 of 6 checks passed
@whiterabbit1983 whiterabbit1983 deleted the f/new-routes branch August 6, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants