-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new routes for docs, users, search #445
Conversation
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 65a0b99 in 33 seconds
More details
- Looked at
1677
lines of code in33
files - Skipped
2
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. agents-api/agents_api/autogen/openapi_model.py:166
- Draft comment:
The introduction of theListResponse
class is a good practice as it standardizes the response format for list endpoints, enhancing API consistency and usability. - Reason this comment was not posted:
Confidence changes required:0%
The PR introduces a new genericListResponse
class inopenapi_model.py
which is used across various list endpoints in the routers. This change is consistent and correctly implemented across the TypeScript SDK, Python SDK, and the actual API routes. This is a good practice as it standardizes the response format for all list endpoints, making the API more predictable and easier to work with for developers.
Workflow ID: wflow_7QbdtyBnpEIvPWZp
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 3b6e81d in 50 seconds
More details
- Looked at
1480
lines of code in29
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. sdks/ts/src/api/services/DefaultService.ts:321
- Draft comment:
The implementation ofagentsDocsSearchRouteSearch
method correctly handles different types of search requests and constructs a proper search response. This aligns well with the backend changes and the updated models for search functionality. - Reason this comment was not posted:
Confidence changes required:0%
The PR introduces new routes and updates to models and SDKs for handling documents and sessions related to agents. The changes include modifications to the search functionality, particularly around handling different types of search requests (text-only, vector, and hybrid) and the responses they generate. The TypeScript SDK and Python SDK files have been updated to reflect these changes, including new types and schemas for handling search requests and responses. The PR seems to align with the intended functionality as described, focusing on enhancing the search capabilities and ensuring the SDKs are up-to-date with the backend changes.
Workflow ID: wflow_mxJCcSuvdtgTPUY6
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
2cf9af5
into
dev-tasks-disable-routes
Summary:
Reimplemented agent and session routes, updated models, and modified SDKs to reflect these changes.
Key points:
agents-api/agents_api/routers/agents
.create_agent
,create_agent_tool
,create_or_update_agent
,delete_agent
,delete_agent_tool
,get_agent_details
,list_agent_tools
,list_agents
,patch_agent
,patch_agent_tool
,update_agent
,update_agent_tool
.agents-api/agents_api/routers/sessions
.create_or_update_session
,create_session
,delete_session
,get_session
,list_sessions
,patch_session
,update_session
.agents-api/agents_api/models
.create_agent
,utils
.agents-api/agents_api/autogen
.Chat.py
,Entries.py
,openapi_model.py
.sdks/python/julep/api/types
.sdks/ts/src/api/services/DefaultService.ts
.typespec/common/interfaces.tsp
.Generated with ❤️ by ellipsis.dev