chore: Disable all the routes except of tasks and agents #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to a1da3e6 in 44 seconds
More details
- Looked at
50lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_g0yRknDArgncQZ0i
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| default_settings=request.default_settings, | ||
| metadata=request.metadata, | ||
| instructions=request.instructions, | ||
| _, updated_agent = next( |
There was a problem hiding this comment.
Using next() and .iterrows() suggests that update_agent_query returns a DataFrame, which is unusual and potentially inefficient for a web API. Consider modifying update_agent_query to return a more suitable data structure, like a dictionary, directly applicable to the API's needs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Disabled all routes except for
tasksandagents, and updated theupdate_agentfunction to usenexton the query result.Key points:
include_routerlines forsessions,users, andjobsinagents-api/agents_api/web.pyto disable these routes.update_agentfunction inagents-api/agents_api/routers/agents/update_agent.pyto usenexton the result ofupdate_agent_queryto get the updated agent details.Generated with ❤️ by ellipsis.dev