Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agents-api): Add get_transition query #438

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Jul 30, 2024

Signed-off-by: Diwank Tomer [email protected]


🚀 This description was created by Ellipsis for commit 535fc62

Summary:

Added get_transition query and resume transition type to agents-api, including validation and error handling.

Key points:

  • Added resume to TransitionType in agents-api/agents_api/autogen/Executions.py, sdks/python/julep/api/types/executions_transition_type.py, sdks/ts/src/api/models/Executions_Transition.ts, and typespec/executions/models.tsp.
  • Implemented get_execution_transition in agents-api/agents_api/models/execution/get_execution_transition.py to fetch a transition by transition_id or task_token.
  • Updated create_execution_transition in agents-api/agents_api/models/execution/create_execution_transition.py to validate transitions using valid_transitions map.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 535fc62 in 37 seconds

More details
  • Looked at 324 lines of code in 7 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/agents_api/autogen/Executions.py:86
  • Draft comment:
    The PR introduces a new transition type 'resume' but lacks a description or context explaining the need for this addition. Please provide a detailed justification for this change to assess its impact and necessity correctly.
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_OFYNTwvpah8CmgeB


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@whiterabbit1983 whiterabbit1983 merged commit 7970748 into dev-tasks Jul 31, 2024
2 of 6 checks passed
@whiterabbit1983 whiterabbit1983 deleted the f/get-transition-query branch July 31, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants