Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdks/ts): Add runtime validations for TS SDK #425

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Jul 1, 2024

  • feat(sdks/ts): Add runtime validations for TS SDK
  • version(sdks/ts): Bump to 0.3.8

🚀 This description was created by Ellipsis for commit 8232a85

Summary:

Added runtime validations using typia for various classes and methods in the TypeScript SDK and bumped version to 0.3.8.

Key points:

  • Added runtime validations using typia in sdks/ts/src/client.ts, sdks/ts/src/managers/agent.ts, sdks/ts/src/managers/base.ts, sdks/ts/src/managers/doc.ts, sdks/ts/src/managers/memory.ts, sdks/ts/src/managers/session.ts, sdks/ts/src/managers/tool.ts, sdks/ts/src/managers/user.ts, and sdks/ts/src/utils/requestConstructor.ts.
  • Removed sdks/ts/src/check.ts.
  • Updated Client constructor to validate ClientOptions.
  • Updated AgentsManager, DocsManager, MemoriesManager, SessionsManager, ToolsManager, and UsersManager methods to validate input parameters.
  • Bumped version to 0.3.8 in sdks/ts/package.json.

Generated with ❤️ by ellipsis.dev

Diwank Tomer added 2 commits July 1, 2024 11:53
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 8232a85 in 24 seconds

More details
  • Looked at 1057 lines of code in 11 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. sdks/ts/src/managers/user.ts:14
  • Draft comment:
    The consistent use of typia.assertGuard and typia.assert across various manager classes enhances runtime type safety and data validation, which is a commendable practice for robust software development.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The use of typia.assertGuard and typia.assert throughout the codebase ensures that the types and formats of the inputs are validated at runtime. This is a good practice for maintaining type safety and ensuring data integrity, especially when dealing with external inputs or API responses. This approach helps prevent bugs and security issues related to invalid data types or formats.

Workflow ID: wflow_WZYvbXqyDEIjaTRf


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@creatorrr creatorrr merged commit 74e1a92 into dev Jul 1, 2024
6 of 9 checks passed
@creatorrr creatorrr deleted the f/runtime-validations-ts-sdk branch July 1, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant