Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tasks): Enable all fields of ExecutionInput #396

Merged
merged 9 commits into from
Jun 21, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Jun 21, 2024

  • feat: Update SDKs and openapi spec
  • feat: Add session_id field to execution relation
  • feat(agents-api): Get execution input query
  • wip
  • feat: Regenerate SDKs
  • wip
  • wip
  • feat(tasks): Enable all fields of ExecutionInput

🚀 This description was created by Ellipsis for commit f1b6839

Summary:

Enabled all fields of ExecutionInput by updating SDKs, OpenAPI spec, and various models and functions in both Python and TypeScript SDKs.

Key points:

  • Updated agents-api/agents_api/autogen/openapi_model.py to include new fields in Execution class.
  • Added session_id field to execution relation in agents-api/agents_api/models/execution/create_execution.py.
  • Implemented get_execution_input_query in agents-api/agents_api/models/execution/get_execution_input.py.
  • Updated agents-api/agents_api/common/protocol/tasks.py to enable all fields of ExecutionInput.
  • Regenerated Python SDK with updated models and functions.
  • Regenerated TypeScript SDK with updated models and functions.
  • Updated sdks/python/julep/api/client.py to handle new fields in ExecutionInput.
  • Updated sdks/python/julep/api/types to include new fields in various models.
  • Updated sdks/ts/src/api to include new fields in various models and schemas.
  • Updated sdks/ts/package.json to use the latest version of dependencies.

Generated with ❤️ by ellipsis.dev

Diwank Tomer and others added 8 commits June 20, 2024 13:01
wip
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Julep Developers <[email protected]>
wip
Signed-off-by: Diwank Tomer <[email protected]>
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f1b6839 in 1 minute and 4 seconds

More details
  • Looked at 2788 lines of code in 39 files
  • Skipped 4 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. sdks/ts/src/api/models/Execution.ts:15
  • Draft comment:
    The session_id field should be marked as optional to maintain consistency with the Python SDK and ensure correct data handling across SDKs.
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_cbvFlsJXlcERrdak


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@whiterabbit1983 whiterabbit1983 merged commit 00a7f02 into dev-tasks Jun 21, 2024
3 of 6 checks passed
@whiterabbit1983 whiterabbit1983 deleted the f/tasks-steps branch June 21, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants