feat(agents-api): cozo queries for tasks #352
Conversation
Signed-off-by: Diwank Tomer <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 7cd1c32 in 1 minute and 20 seconds
More details
- Looked at
91lines of code in4files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_OJsXWvaq97rGsnCS
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 5406a2b in 2 minutes and 1 seconds
More details
- Looked at
32lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/agents_api/routers/tasks/routers.py:66
- Draft comment:
The PR description states thatdeveloper_idshould be replaced withagent_id. Please update the parameter accordingly to align with the new entity identification strategy. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_z8lrZERTUDk200lT
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 05ec664 in 1 minute and 9 seconds
More details
- Looked at
83lines of code in3files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_nU2hpv1ypRPA138O
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
agents-api/agents_api/models/execution/list_execution_transitions.py
Outdated
Show resolved
Hide resolved
agents-api/agents_api/models/execution/update_execution_transition.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
❌ Changes requested. Incremental review on e630a55 in 1 minute and 59 seconds
More details
- Looked at
94lines of code in3files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_ckAg0lSO0vtIW8Qx
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
agents-api/agents_api/models/execution/update_execution_status.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 6f9dab5 in 5 minutes and 23 seconds
More details
- Looked at
2179lines of code in23files - Skipped
2files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/agents_api/models/execution/create_execution.py:6
- Draft comment:
The function signature still includesdeveloper_idwhich contradicts the PR's goal of usingagent_id. This should be updated to useagent_idto align with the rest of the changes in the PR. - Reason this comment was not posted:
Confidence of 30% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_fqRQIckG58zXeA4V
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Signed-off-by: Diwank Tomer <[email protected]>
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on c39ca0a in 3 minutes and 38 seconds
More details
- Looked at
196lines of code in5files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. agents-api/agents_api/models/task/get_task.py:13
- Draft comment:
Thedeveloper_idparameter is not used in theget_task_queryfunction and contradicts the PR's goal of usingagent_id. Consider removing this parameter if it's not needed.
agent_id: UUID, task_id: UUID
- Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
2. agents-api/agents_api/models/task/list_tasks.py:7
- Draft comment:
Thedeveloper_idparameter is not used in thelist_tasks_queryfunction and contradicts the PR's goal of usingagent_id. Consider removing this parameter if it's not needed.
agent_id: UUID,
- Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_jVHw0GBZLCDVTu5g
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Signed-off-by: Diwank Tomer <[email protected]>
creatorrr
changed the title
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 3c241b2 in 1 minute and 13 seconds
More details
- Looked at
575lines of code in11files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/agents_api/models/execution/create_execution.py:12
- Draft comment:
The function still usesdeveloper_idwhich contradicts the PR's goal of usingagent_id. This inconsistency should be addressed across all execution model functions.
This comment applies to all execution model functions where developer_id is still used.
- Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_YXaeeFhaNaSCJqXO
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Signed-off-by: Diwank Tomer [email protected]
Summary:
This PR updates task and execution querying functions to use
agent_id, adds tests, and modifies routers, but retainsdeveloper_idin execution queries, contradicting its goal.Key points:
create_task_query,get_task_query, andlist_tasks_queryto useagent_id.developer_idin execution queries, contradicting the PR's goal.Generated with ❤️ by ellipsis.dev