-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix zones constrains list parsing #1054
Conversation
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks for the fix!
/merge |
Hey @luissimas, we can't currently merge your contribution as the commit is not signed and our repo has a rule disallowing merges of unverified commits. Would you be able to follow this GitHub guide and force push a verified version of your commit? |
Done. I've also rebased on the main branch. |
/merge |
/build |
1 similar comment
/build |
/merge |
/build |
Signed-off-by: Luís Simas <[email protected]>
/build |
/merge |
#1071 ## What's Changed * fix parsing of storage constraints by @luissimas in #1053 * Add setuptools to tox.ini by @Aflynn50 in #1058 * fix(refresh): bug with revisions by @jack-w-shaw in #1067 * feat: conventional commits static analysis by @SimonRichardson in #1068 * fix(series): add noble support by @jack-w-shaw in #1063 * fix zones constrains list parsing by @luissimas in #1054 * fix(model): fix wrong instanciation of list-secrets facade by @gboutry in #1065 * fix(makefile): run .tox before lint in makefile target by @cderici in #1069
Description
Closes #1050. This fixes the parsing of the
zones
constraint in bundles. The format in the Juju API is defined in: https://github.com/juju/juju/blob/3.6/core/constraints/constraints.go#L107.QA Steps
The following python script can be used to verify both the bug in the current version as well as the fix implemented:
All CI tests need to pass.