-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make layout configurable between Standalone and Base #233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition 👍 I would add this new function to the test with name format_swagger_config_with_multiple_fields
and update the test to cover this use_base_layout()
case as well :)
I also updated the tests now, but I somehow cannot run the test suit because the build of utoipa-gen fails:
Which is weird because it works when I compile when importing the code from another project 🤨 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code does look fine 🥇 :)
That's really weird. It should compile though. If you run the I ran the command above and even with nightly |
I am on Actually it works when I run the test suite with the command you provide, though some tests are failing because of the ordering of the arguments 🙄. But just using |
Anyway tests are fixed now, that I could actually run them :D … |
Right. Most of the tests needs some flags in order to work. And cannot use
Awesome.. 🏆 |
Hey,
I added an option to the Config in Swagger to enable toggling between Standalone and Base Layout.
Kind regards,
ju6ge