Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge paths if they already are added to the paths map in utoipa-axum #1171

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Merge paths if they already are added to the paths map in utoipa-axum #1171

merged 1 commit into from
Oct 28, 2024

Conversation

hdoordt
Copy link
Contributor

@hdoordt hdoordt commented Oct 28, 2024

The old version of the diff would overwrite old routes to the paths map even if they had a different method, so this change merges them instead

@hdoordt hdoordt changed the title Merge paths if they already are added to the paths map Merge paths if they already are added to the paths map in utoipa-axum Oct 28, 2024
juhaku
juhaku requested changes Oct 28, 2024
View reviewed changes
Copy link
Owner

@juhaku juhaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for fixing, 👍 Could you add a CHANGELOG entry top of the file for this change.

## Unreleased

### Changed

* This is the PR title (link)

utoipa-axum/src/router.rs Outdated Show resolved Hide resolved
@hdoordt
Copy link
Contributor Author

hdoordt commented Oct 28, 2024 •
edited
Loading

@juhaku Thanks for having a look. I've updated the CHANGELOG and removed the clone call

juhaku
juhaku reviewed Oct 28, 2024
View reviewed changes
utoipa-axum/CHANGELOG.md Outdated Show resolved Hide resolved
@hdoordt hdoordt requested a review from juhaku October 28, 2024 11:40
juhaku
juhaku approved these changes Oct 28, 2024
View reviewed changes
Copy link
Owner

@juhaku juhaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, 👍

@juhaku juhaku merged commit 8a5ed1e into juhaku:master Oct 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juhaku juhaku juhaku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hdoordt @juhaku