fix EventMachine function call sequence #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jugyo
pushed a commit
that referenced
this pull request
Apr 6, 2014
fix EventMachine function call sequence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventMachinewhat is used intwitter-streamdisallows callingstart_tlsafter you start receiving or sending data. The official document describes about it:In EventMachine,
SslBoxis set non-null value whenStartTlsis called, so nextstart_tlswill callsSetTlsParmsover Ruby code and it occurs C++ exception what says "call SetTlsParms before calling StartTls".Current earthquake.gem misses correct function call sequence. This is already represented in #118. I just created this Pull Request with commentary from it.
See also: Google search: "earthquake" "call SetTlsParms before calling StartTls", Twitter search: earthquake "call SetTlsParms before calling StartTls"