[Discover] Remove sidebar item drag icon

jughosta · Sep 7, 2023 · 1d8ae3b · 1d8ae3b
1 parent ab2c54e
commit 1d8ae3b
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 86 deletions.
diff --git a/packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.scss b/packages/kbn-unified-field-list/src/components/field_item_button/field_item_button.scss
@@ -70,36 +70,3 @@
   background: lightOrDarkTheme(transparentize($euiColorMediumShade, .9), $euiColorEmptyShade);
   color: $euiColorDarkShade;
 }
-
-// A drag handle will appear only on item hover/focus
-.unifiedFieldListItemButton--withDragHandle {
-  &.kbnFieldButton {
-    padding: 0;
-    margin-bottom: $euiSizeXS / 2;
-  }
-
-  .kbnFieldButton__dragHandle {
-    margin-right: 0;
-    width: 0;
-    overflow: hidden;
-    transition: $euiAnimSpeedNormal ease-in-out;
-    transition-property: width, margin-right;
-  }
-
-  &.domDragDrop-isDraggable {
-    box-shadow: none;
-  }
-  &.domDragDrop-isDraggable:hover {
-    transform: none;
-  }
-
-  &:hover,
-  &[class*='-isActive'],
-  .domDragDrop__keyboardHandler:focus + &,
-  &:focus-within {
-    .kbnFieldButton__dragHandle {
-      margin-right: $euiSizeS;
-      width: $euiSize;
-    }
-  }
-}
diff --git a/packages/kbn-unified-field-list/src/containers/unified_field_list_item/field_list_item.tsx b/packages/kbn-unified-field-list/src/containers/unified_field_list_item/field_list_item.tsx
@@ -25,14 +25,11 @@ import {
   UnifiedFieldListItemStats,
   type UnifiedFieldListItemStatsProps,
 } from './field_list_item_stats';
-import { FieldListItemHandle } from './field_list_item_handle';
 import type {
   UnifiedFieldListSidebarContainerStateService,
   AddFieldFilterHandler,
 } from '../../types';
 
-const DRAG_HANDLE = <FieldListItemHandle />;
-
 interface GetCommonFieldItemButtonPropsParams {
   stateService: UnifiedFieldListSidebarContainerStateService;
   field: DataViewField;
@@ -343,7 +340,6 @@ function UnifiedFieldListItemComponent({
             isActive={infoIsOpen}
             flush={alwaysShowActionButton ? 'both' : undefined}
             shouldAlwaysShowAction={alwaysShowActionButton}
-            dragHandle={isDragDisabled ? undefined : DRAG_HANDLE}
             onClick={field.type !== '_source' ? togglePopover : undefined}
             {...getCommonFieldItemButtonProps({ stateService, field, isSelected, toggleDisplay })}
           />

diff --git a/.../kbn-unified-field-list/src/containers/unified_field_list_item/field_list_item_handle.tsx b/.../kbn-unified-field-list/src/containers/unified_field_list_item/field_list_item_handle.tsx
diff --git a/.../kbn-unified-field-list/src/containers/unified_field_list_sidebar/field_list_sidebar.scss b/.../kbn-unified-field-list/src/containers/unified_field_list_sidebar/field_list_sidebar.scss
@@ -43,3 +43,14 @@
 .unifiedFieldListSidebar__flyoutHeader {
   align-items: center;
 }
+
+.unifiedFieldListSidebar .unifiedFieldListItemButton {
+  &.kbnFieldButton {
+    padding: 0;
+    margin-bottom: $euiSizeXS / 2;
+  }
+
+  &.domDragDrop-isDraggable {
+    box-shadow: none;
+  }
+}