fix: lock GoodJob dependency to < 4.0 #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoodJob v4 was recently released, but that has some breaking changes that don't work well with Judoscale yet. Before adding full support to the new version, we're doing a patch release to lock it to version < 4, so that people trying to install both don't run into problems using GoodJob v4 and Judoscale. https://island94.org/2024/07/introducing-goodjob-v4
carlosantoniodasilva
force-pushed
the
ca-good-job-lock-version
branch
from
7def621 to
4561ce4
Compare
carlosantoniodasilva
added a commit
that referenced
this pull request
Jul 8, 2024
[1.7.1](v1.7.0...v1.7.1) (2024-07-08) Bug Fixes * Lock GoodJob dependency to < 4.0 ([#211](#211)) ([d558584](d558584)) * Fix Rack version to work across multiple released versions ([dd0c08c](dd0c08c)) --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Carlos Antonio da Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GoodJob v4 was recently released, but that has some breaking changes that don't work well with Judoscale yet. Before adding full support to the new version, we're doing a patch release to lock it to version < 4, so that people trying to install both don't run into problems using GoodJob v4 and Judoscale.
https://island94.org/2024/07/introducing-goodjob-v4