Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci fixes #194

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Ci fixes #194

merged 4 commits into from
Jan 25, 2024

Conversation

adamlogic
Copy link
Collaborator

No description provided.

Our CI tests run for a matrix of Ruby versions, and having a single Gemfile.lock was causing problems for some spec dependencies that aren't supported by all versions (nokogiri 1.16.0 wasn't working with Ruby 2.7).

By keeping the lock files out of version control, our tests will always regenerate a lock file by resolving dependencies with the current Ruby version.
Not needed since Gemfile.lock has been removed from Git.
@adamlogic adamlogic merged commit 03e64c7 into main Jan 25, 2024
61 checks passed
@adamlogic adamlogic deleted the ci-fixes branch January 25, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant