Mark the reporter thread as "fork safe" to avoid warnings #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the Reporter thread from generating warnings with puma, which has been warning on any threads created before forking.
The Reporter thread is aware of forking by keeping the current
pid
around, and initializing another thread if thepid
changes. It means we still have a running Reporter on the main puma process in this case, plus one for each forked process (if running in cluster mode, in case of puma.)References:
rails/rails#40399
puma/puma#2475
https://github.com/puma/puma/releases/tag/v5.1.0
Closes #170