Added Dockerfile and entrypoint script to configure API Urls #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40-env-update.sh
Outdated
| echo API URL Already set to $API_URL | ||
| else | ||
| echo Setting API URL to: $API_URL | ||
| sed -i "s#var apiUrl = defaultUrl#const apiUrl = '$API_URL'#" /usr/share/nginx/html/js/ide.js |
There was a problem hiding this comment.
This line causes runtime errors since the variable apiUrl is re-assigned within ide.js. To fix this, replace the const keyword with var.
Also, it seems like the defaultUrl variable is still used in some places. A possible fix would be to also replace this line in the code to a hard-coded value. Same goes for the extraApiUrl variable.
|
I'll update that tonight. Thanks! |
added 2 commits
August 21, 2023 10:53
…rences to defaultUrl in ide.js
|
I've updated my code to remove all references to defaultUrl and put the contents into apiUrl directly. I also changed my const to a var to match your request. When i get more time, i'll add some changes to allow an environment variable to update the extraApiUrl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a basic Dockerfile that will allow people that are self-hosting the API to also spin up the IDE easily and configure the API URL setting by specifying an environment variable called
API_URLBuild the image:
docker build -t judge0-ide .Run Locally:
docker run -d -p 8080:80 --name judge0-ide -e API_URL="https://api.example.com" judge0-ide