Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better unit testing #54

Open
judah opened this issue Dec 28, 2017 · 0 comments
Open

Better unit testing #54

judah opened this issue Dec 28, 2017 · 0 comments
Labels
Epic

Comments

@judah
Copy link
Owner

judah commented Dec 28, 2017

Add explicit unit tests, instead of (or in addition to) the mass-package-compile that's currently in the CircleCI scripts.

Ideally this would let us decrease the time for CircleCI to run significantly, for example by avoiding large packages like haskell-src-exts and language-c.
@judah judah added the Epic label Dec 28, 2017
judah added a commit that referenced this issue Dec 31, 2017
@judah
Generate Cabal macros (VERSION_*, MIN_VERSION_*).
4447cb6 
Also add explicit exports for the Config module.

This is needed for `pandoc` in lts-8.0`.  Deferring tests to #54.
judah added a commit that referenced this issue Dec 31, 2017
@judah
Generate Cabal macros (VERSION_*, MIN_VERSION_*).
47de4cf 
Also:
- Make a datatype for a "configured" package
- Add explicit exports to the Config module.

This is needed for `pandoc` in lts-8.0`.  Deferring tests to #54.
judah added a commit that referenced this issue Dec 31, 2017
@judah
Make all paths relative to the stack.yaml file.
9e2d616 
- Location of `_stake/`
- Location of local `package` paths

It's a little hacky because it uses `getCurrentDirectory` rather than passing around
the root directory.

Unit testing deferred to #54.

Progress towards #55.
judah added a commit that referenced this issue Dec 31, 2017
@judah
Look in parent directories for stack.yaml.
0faf6e6 
Fixes #55.

Unit testing deferred to #54.
judah added a commit that referenced this issue Jan 27, 2018
@judah
Use package flags from the build plan.
ffc8d5f 
Partial work towards #59; user flags aren't implemented yet.

Enables building the `alerta` package, though currently that doesn't
finish due issues with its dependencies.

Deferring unit testing to #54.
judah added a commit that referenced this issue Jan 27, 2018
@judah
Use package flags from the build plan.
ef08767 
Partial work towards #59; user flags aren't implemented yet.

Enables building the `alerta` package, though currently that doesn't
finish due issues with its dependencies.

Deferring unit testing to #54.
judah added a commit that referenced this issue Feb 3, 2018
@judah
More edge-case fixes.
b1b8c21 
- Fix the `xhtml` package by doing a better job filtering out built-in
  packages that aren't in the build plan.
- Fix `Paths_` modules for packages with dashes in their name.  (Unit testing
  deferred to #54.)
judah added a commit that referenced this issue Feb 4, 2018
@judah
Fix happy/alex on older LTSes.
ec24f7c 
For those packages specifically, add "dist/build/NAME/NAME-tmp" to the
source-dirs of exes, since that's where earlier versions put their bootstrapped
source files.

Progress on #61, though it the way executables are built is still a little
fragile.

Deferring unit testing to #54.
judah added a commit that referenced this issue Feb 5, 2018
@judah
Fix #61: happy/alex on older LTSes.
f231409 
For those packages specifically, add "dist/build/NAME/NAME-tmp" to the
source-dirs of exes, since that's where earlier versions put their bootstrapped
source files.

Also wrap building executables in rules, which would have caught this infinite loop.

Deferring unit testing to #54.
judah added a commit that referenced this issue Feb 7, 2018
@judah
pier run should run under the project root directory.
dd6789d 
Deferring unit testing to #54.
judah added a commit that referenced this issue Feb 7, 2018
@judah
pier run should run under the project root directory.
b95d4da 
Deferring unit testing to #54.
judah added a commit that referenced this issue Feb 7, 2018
@judah
pier run should run under the project root directory.
d56d681 
Deferring unit testing to #54.
judah added a commit that referenced this issue Feb 8, 2018
@judah
Build the Paths module with ImplicitPrelude.
c0c9363 
Helps packages that turn on `NoImplicitPrelude` or `RebindableSyntax`
(which implies the former).

Deferring testing to #54.  I couldn't find a good canonical example.
Some that this fixed: `aern2-real`, `eventstore` and `numhask`.
judah added a commit that referenced this issue Feb 8, 2018
@judah
Build the Paths module with ImplicitPrelude.
965277b 
Helps packages that turn on `NoImplicitPrelude` or `RebindableSyntax`
(which implies the former).

Deferring testing to #54.  I couldn't find a good canonical example.
Some that this fixed: `aern2-real`, `eventstore` and `numhask`.
judah added a commit that referenced this issue Feb 8, 2018
@judah
Build the Paths module with ImplicitPrelude.
b9ba1c0 
Helps packages that turn on `NoImplicitPrelude` or `RebindableSyntax`
(which implies the former).

Deferring testing to #54.  I couldn't find a good canonical example.
Some that this fixed: `aern2-real`, `eventstore` and `numhask`.
judah added a commit that referenced this issue Mar 4, 2018
@judah
Fix edge case in dedupArtifacts.
164b310 
If a command had the inputs ["Foo", "Foo.hs" and "Foo/Bar.hs"] then
the last once wouldn't be removed.  We were relying on lexicographic
sorting, but `'.' < '/'`.

TODO #54: unit test this better.
judah added a commit that referenced this issue Mar 5, 2018
@judah
Support Mac frameworks.
6fb974b 
Fixes (only on Mac) `hfsevents`, as well as `fsevents` which depends on it.

TODO(#54): unit test this (but only on Mac).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Epic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@judah