Fix issue 9348: FP uninitvar for pointer passed to memcpy (danmar#2167)

jubnzv · Nov 13, 2019 · 6fa0716 · 6fa0716
1 parent 7c6a29d
commit 6fa0716
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/astutils.cpp b/lib/astutils.cpp
@@ -1051,7 +1051,7 @@ bool isVariableChangedByFunctionCall(const Token *tok, int indirect, const Setti
                      argDirection == Library::ArgumentChecks::Direction::DIR_INOUT) {
                 // With out or inout the direction of the content is specified, not a pointer itself, so ignore pointers for now
                 const ValueType * const valueType = tok1->valueType();
-                if (valueType && !valueType->pointer) {
+                if (valueType && valueType->pointer == indirect) {
                     return true;
                 }
             }

diff --git a/test/testuninitvar.cpp b/test/testuninitvar.cpp
@@ -4448,6 +4448,17 @@ class TestUninitVar : public TestFixture {
                         "        return;\n"
                         "}\n");
         ASSERT_EQUALS("", errout.str());
+
+        // # 9348
+        valueFlowUninit("void f(int *a) {\n"
+                        "  int b = 0;\n"
+                        "  memcpy(a, &b, sizeof(b));\n"
+                        "}\n"
+                        "void g() {\n"
+                        "  int i;\n"
+                        "  f(&i);\n"
+                        "}\n");
+        ASSERT_EQUALS("", errout.str());
     }
 
     void uninitvar_memberfunction() {