Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.7 compatibility and Port Audio Error #29

Merged
merged 7 commits into from
Apr 26, 2022

Conversation

Yagna24
Copy link
Contributor

@Yagna24 Yagna24 commented Mar 10, 2022

Added imports for Python3.7 compatibility

Added doc links to set up PortAudio and Soundevice on local windows machine.

Added install command to set up the same on google colab.

@Yagna24 Yagna24 closed this Mar 10, 2022
@Yagna24 Yagna24 reopened this Mar 10, 2022
@Yagna24 Yagna24 closed this Mar 11, 2022
@Yagna24 Yagna24 reopened this Mar 11, 2022
@juanmc2005 juanmc2005 self-requested a review April 7, 2022 11:29
@juanmc2005 juanmc2005 added the feature New feature or request label Apr 7, 2022
@juanmc2005 juanmc2005 added this to the Version 0.3 milestone Apr 7, 2022
Copy link
Owner

@juanmc2005 juanmc2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for uploading this PR and sorry it took me some time to review it.
I'd like to remove the changes to the readme and I think there's another bad import for python 3.7 in sinks.py

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/diart/functional.py Show resolved Hide resolved
@juanmc2005 juanmc2005 changed the base branch from main to develop April 7, 2022 13:43
@juanmc2005 juanmc2005 merged commit d499ef0 into juanmc2005:develop Apr 26, 2022
@juanmc2005 juanmc2005 mentioned this pull request May 18, 2022
juanmc2005 added a commit that referenced this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants