Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PipelineConfig.from_dict() #189

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Remove PipelineConfig.from_dict() #189

merged 3 commits into from
Oct 19, 2023

Conversation

juanmc2005
Copy link
Owner

This PR addresses issue #157

Changelog

  • Remove PipelineConfig.from_dict() and use __init__() instead
  • Improve typing annotations in VAD and Diarization pipelines
  • Rename --tau to --tau-active
  • Rename --rho to --rho-update
  • Rename --delta to --delta-new
  • Add --duration to diart.stream, diart.serve, diart.tune and diart.benchmark

@juanmc2005 juanmc2005 added the refactoring Internal design improvements that don't change the API label Oct 19, 2023
@juanmc2005 juanmc2005 added this to the Version 0.8 milestone Oct 19, 2023
@juanmc2005 juanmc2005 merged commit 0113ab2 into develop Oct 19, 2023
@juanmc2005 juanmc2005 deleted the simpler_config branch October 19, 2023 16:21
This was referenced Oct 19, 2023
Closed
Merged
juanmc2005 added a commit that referenced this pull request Oct 28, 2023
@juanmc2005
Remove PipelineConfig.from_dict() (#189)
344599a 
* Unify hparam naming. Clean some typing annotations

* Remove config.from_dict(). Add --duration argument to CLI

* Update README.md accordingly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring Internal design improvements that don't change the API
Projects
None yet
Milestone
Version 0.8
Development

Successfully merging this pull request may close these issues.
1 participant
@juanmc2005