Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joss] Use ABC and abstractmethod rather than NotImplementedError #173

Closed
wants to merge 2 commits into from

Conversation

sneakers-the-rat
Copy link
Contributor

@sneakers-the-rat sneakers-the-rat commented Oct 4, 2023

NotImplementedError has slightly different semantics and effects than using ABC and abstractmethod - ABC classes can't be instantiated without satisfying all their abstractmethods, vs. raising an error which might not be obvious until the class is actually used. This also allows for static analysis tools to warn you when you haven't completed all the abstractmethods :)

part of: openjournals/joss-reviews#5266

@juanmc2005 juanmc2005 self-requested a review October 6, 2023 09:52
@juanmc2005 juanmc2005 added the refactoring Internal design improvements that don't change the API label Oct 6, 2023
@juanmc2005 juanmc2005 added this to the Version 0.8 milestone Oct 6, 2023
@juanmc2005 juanmc2005 changed the base branch from main to develop October 6, 2023 09:54
@juanmc2005
Copy link
Owner

Refer to rebased version -> #179

@juanmc2005 juanmc2005 closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal design improvements that don't change the API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants