Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plug & play speaker diarization pipelines #101

Merged
merged 8 commits into from
Jan 31, 2023
Merged

Plug & play speaker diarization pipelines #101

merged 8 commits into from
Jan 31, 2023

Conversation

juanmc2005
Copy link
Owner

This PR addresses issue #96 and introduces a new feature for custom pipelines.

Changelog

  • Add BasePipelineConfig and BasePipeline as minimal interfaces to respect for custom pipelines
    • A config must provide sample_rate, duration, step and latency
    • A pipeline must provide a config, it must be callable and be able to reset its internal state
  • Make RealTimeInference, Benchmark and Optimizer fully compatible with any pipeline adhering to the interface
  • Fix bug diart.tune doesn't initialize to custom hyper-parameters #96

The next step for custom pipelines would be that the CLI interface supports it, which is a bit more complicated because the CLI also builds the config.

@juanmc2005 juanmc2005 added bug Something isn't working feature New feature or request labels Sep 28, 2022
@juanmc2005 juanmc2005 added this to the Version 0.6 milestone Sep 28, 2022
@juanmc2005 juanmc2005 added the API Improvements to the API label Oct 19, 2022
@juanmc2005 juanmc2005 modified the milestones: Version 0.6, Version 0.7 Oct 28, 2022
@juanmc2005 juanmc2005 linked an issue Jan 31, 2023 that may be closed by this pull request
@juanmc2005 juanmc2005 marked this pull request as ready for review January 31, 2023 10:31
@juanmc2005 juanmc2005 merged commit 77aea66 into develop Jan 31, 2023
@juanmc2005 juanmc2005 deleted the fix/hparams branch January 31, 2023 13:12
@juanmc2005 juanmc2005 mentioned this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Improvements to the API bug Something isn't working feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

diart.tune doesn't initialize to custom hyper-parameters
1 participant