Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to allow headscale to start if OIDC fails to initialise #829

Merged
merged 6 commits into from
Sep 26, 2022

Conversation

kradalby
Copy link
Collaborator

@kradalby kradalby commented Sep 26, 2022

OIDC might be configured, but unable to be initialised, this only runs
the oidc cycle if it is actually successfully set up/initialised.

Fixes #827

Signed-off-by: Kristoffer Dalby [email protected]

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

OIDC might be configured, but unable to be initialised, this only runs
the oidc cycle if it is actually successfully set up/initialised.

Prep for next commit

Signed-off-by: Kristoffer Dalby <[email protected]>
This commit makes headscale fall back to CLI authentication if oidc
fails to initialised and posts a warning to users.

Signed-off-by: Kristoffer Dalby <[email protected]>
Add a configuration flag (default true to preserve current behaviour) to
allow headscale to start without OIDC being able to initialise.

Signed-off-by: Kristoffer Dalby <[email protected]>
Signed-off-by: Kristoffer Dalby <[email protected]>
Signed-off-by: Kristoffer Dalby <[email protected]>
@kradalby kradalby marked this pull request as ready for review September 26, 2022 08:02
@kradalby kradalby requested a review from juanfont as a code owner September 26, 2022 08:02
@kradalby kradalby merged commit 5f975cb into juanfont:main Sep 26, 2022
@kradalby kradalby deleted the oidc-dependency branch September 26, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to bring headscale up if OIDC is down
2 participants