Add /windows endpoint for Windows configuration + /apple endpoint cleanup #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename the gin function to AppleConfigMessage - use <pre> + <code> for code blocks - add headscale heading - reword some sections
- registry file /windows/tailscale.reg is generated, filling in the associated control server URL - also includes CLI instructions - fix /apple incorrect template: 'Url' is supposed to be '.URL'
rename apple_mobileconfig.go to platform_config.go since the file includes configuration info for multiple platforms now.
juanfont
previously approved these changes
Mar 4, 2022
| <!-- | ||
| <p><code>curl {{.Url}}/apple/ios</code></p> | ||
| <pre><code>curl {{.URL}}/apple/ios</code></pre> |
There was a problem hiding this comment.
Should we add a note here saying that it is not currently working?
There was a problem hiding this comment.
It is commented out, <!-- so it does not show up on the html page
|
Looks sensible, just need the golangcilint to pass :) |
kradalby
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #340.
/windows:.regfile/windows/tailscale.reg/applechanges:AppleConfigMessageto matchWindowsConfigMessage./appleused.Url, when the correct variable needed to be.URL. This has been fixed.